zone: fix error caused subzone placeholders not inheriting from parents #44266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Thanks nathan for the repro! I was kind of staring at this error coming up on the tpcc failures and unsure how to debug it any further... |
nvanbenschoten
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
It's worth pointing out in the commit message that while this isn't a full backport of #40493, it is a partial backport of that change. That makes this easier to justify as a backport target.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Fixes cockroachdb#44231. Fixes cockroachdb#41553. This PR fixes a bug caused by backports. In short, the backport of cockroachdb#41506 to 19.1 did not include some code in cockroachdb#40493 which allowed a subzone placeholder to inherit fields from its parents. This caused a problem the second time a index's zone was altered, because its parent (now a subzone placeholder) would no longer be able to inherit values from its parent. We couldn't backport cockroachdb#40493 because it contained features that were only released in 19.2, and since there was not a test checking this specific behavior, we didn't catch the regression on 19.1. Therefore, this PR contains a partial backport of cockroachdb#40493. Release note (bug fix): Fix a bug where repeated use of COPY FROM PARENT on an index or partition could cause an unexpected validation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44231.
Fixes #41553.
This PR fixes a bug caused by backports.
In short, the backport of #41506 to 19.1 did not include some code
in #40493 which allowed a subzone placeholder to inherit fields
from its parents. This caused a problem the second time a index's
zone was altered, because its parent (now a subzone placeholder)
would no longer be able to inherit values from its parent.
We couldn't backport #40493 because it contained features that
were only released in 19.2, and since there was not a test checking
this specific behavior, we didn't catch the regression on 19.1.
Therefore, this PR contains a partial backport of #40493.
Release note (bug fix): Fix a bug where repeated use of COPY FROM PARENT
on an index or partition could cause an unexpected validation error.