Commits on Jan 28, 2020

1. libroach,engine: support pagination of ExportToSst …

   This commit extends the engine interface to take a targetSize parameter in
   the ExportToSst method. The iteration will stope if the first version of a key
   to be added to the SST would lead to targetSize being exceeded. If
   exportAllRevisions is false, the targetSize will not be exceeded unless the
   first kv pair exceeds it.
   
   This commit additionally fixes a bug in the rocksdb implementation of
   DBExportToSst whereby the first key in the export request would be skipped.
   This case likely never occurred because the key passed to Export was rarely
   exactly the first key to be included (see the change related to seek_key in
   db.cc).
   
   The exportccl.TestRandomKeyAndTimestampExport was extended to excercise various
   targetSize limits. That test run under stress with the tee engine inspires some
   confidence and did catch the above mentioned bug. More testing would likely be
   good.
   
   This commit leaves the task of adopting the targetSize parameter for later.
   
   Fixes cockroachdb#39717.
   
   Release note: None

   

   ajwerner committed Jan 28, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 05f91e5
   • Browse repository at this point

   Copy the full SHA

   05f91e5 View commit details

   Browse the repository at this point in the history