sqlbase: plumb DummyPrivilegedAccessor to relevant initializers #45413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
reviewed
Feb 25, 2020
pkg/sql/planner.go
Outdated
| p.extendedEvalCtx.SessionAccessor = p | ||
| p.extendedEvalCtx.PrivilegedAccessor = p |
There was a problem hiding this comment.
i'm just tryna keep the order the same hahahah
|
lgtm aside from nit |
|
Oh i didn't notice that -- i don't mind either way |
|
bors r=rohany |
Build failed |
No functional change but a help with debugging, initialize PrivilegedAccessor with a dummy one much like we do with SessionAccessor. Release note: None
|
bors r=rohany |
Build failed |
|
bors r=rohany
Flake with bench again.
…On Wed, 26 Feb 2020, 1:26 pm craig[bot], ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1766677&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45413?email_source=notifications&email_token=AA32FQ6GB2APDRXECXQJ3GDREXHL7A5CNFSM4K3WDVWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM6RDQQ#issuecomment-591204802>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA32FQ6VUM45MQDJPFQDAL3REXHL7ANCNFSM4K3WDVWA>
.
|
Build failed |
|
bors r=rohany
Different flake....
…On Wed, 26 Feb 2020, 2:02 pm craig[bot], ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1766742&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45413?email_source=notifications&email_token=AA32FQ24C6JF76P5QILERTDREXLTJA5CNFSM4K3WDVWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM6TIIY#issuecomment-591213603>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA32FQ3LTL6G5GUSYTJ6XC3REXLTJANCNFSM4K3WDVWA>
.
|
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #45408
No functional change but a help with debugging, initialize
PrivilegedAccessor with a dummy one much like we do with
SessionAccessor.
Release note: None