sql: fix error message when renaming databases with dependent sequences #45427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Changes LGTM, but I find the error message still a bit not informative enough. What about |
|
i've put the full schema lookup name on the |
|
I think the table should have a qualified name as well then |
ah yeah that's what i meant. PR update incoming, check the tests |
otan
force-pushed
the
fix_error_message
branch
from
258190e to
5104de7
Compare
|
ah woops, missed a spot! |
otan
force-pushed
the
fix_error_message
branch
from
5104de7 to
fe4c3fb
Compare
|
The code LGTM, a good number of failing tests to fix though. |
|
hahaa just the one |
Release note (bug fix): Previously, renaming a database with dependent views returned a misleading error message that implies it was a dependent view on a dependent table. This PR renames the error message generically to `cannot rename relation ... as it depends on relation ...` instead.
otan
force-pushed
the
fix_error_message
branch
from
fe4c3fb to
60a8ebe
Compare
|
bors r=rohany |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #45411
Release note (bug fix): Previously, renaming a database with dependent
views returned a misleading error message that implies it was a
dependent view on a dependent table. This PR renames the error message
generically to
cannot rename relation ... as it depends on relation ...instead.