closedts: avoid logging failures on startup #45460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
TFTR! bors r=tbg |
Build failed (retrying...) |
|
bors r=tbg |
Before this commit it was commonly the case that nodes would fail to move the closed timestamp due to not being live when they start up. This warning was concerning to customers. Now we'll track whether we've ever been live and only log if we find that we are not live later. Fixes cockroachdb#44846 Release note: None
ajwerner
force-pushed
the
ajwerner/silence-closedts-on-startup
branch
from
c7c5786 to
99021d6
Compare
|
bors r=tbg |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit it was commonly the case that nodes would fail to move the
closed timestamp due to not being live when they start up. This warning was
concerning to customers. Now we'll track whether we've ever been live and only
log if we find that we are not live later.
Fixes #44846
Release note: None