release-19.1: pgwire: fix decimal decoding with trailing zeroes #45671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In addition to the release note, I have also modified the docker runfile to support elixir tests, and also updated the elixir tests to be run. Release note (bug fix): In previous PRs, drivers that do not truncate trailing zeroes for decimals in the binary format end up having inaccuracies of up to 10^4 during the decode step. In this PR, we fix the error by truncating the trailing zeroes as appropriate. This fixes known incorrect decoding cases with Postgrex in Elixir.
jordanlewis
reviewed
Mar 4, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
Dedej-Bergin
pushed a commit
to Dedej-Bergin/cockroach
that referenced
this pull request
Dec 19, 2024
…ented.go Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer. Fixes: cockroachdb#45671 Release note: none
Dedej-Bergin
pushed a commit
to Dedej-Bergin/cockroach
that referenced
this pull request
Dec 19, 2024
…ented.go Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer. Fixes: cockroachdb#45671 Release note: none
Dedej-Bergin
pushed a commit
to Dedej-Bergin/cockroach
that referenced
this pull request
Dec 19, 2024
…ented.go Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer. Fixes: cockroachdb#45671 Release note: none
Dedej-Bergin
pushed a commit
to Dedej-Bergin/cockroach
that referenced
this pull request
Dec 19, 2024
…ented.go Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer. Fixes: cockroachdb#45671 Release note: none
craig bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
137795: sql: refactor unimplemented statements into one file pkg/sql/unimplem… r=Dedej-Bergin a=Dedej-Bergin …ented.go Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer. Fixes: #45671 Release note: none Co-authored-by: Bergin Dedej <bergin.dedej@cockroachlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #45613.
/cc @cockroachdb/release
Resolves #25460
In addition to the release note, I have also modified the docker runfile
to support elixir tests, and also updated the elixir tests to be run.
Release note (bug fix): In previous PRs, drivers that do not truncate
trailing zeroes for decimals in the binary format end up having
inaccuracies of up to 10^4 during the decode step. In this PR, we fix
the error by truncating the trailing zeroes as appropriate. This fixes
known incorrect decoding cases with Postgrex in Elixir.