sql: update kvtrace logictest option to accept parameters #45952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
force-pushed
the
better-kvtrace
branch
2 times, most recently
from
ecdc04b to
7726fd2
Compare
RaduBerinde
reviewed
Mar 10, 2020
There was a problem hiding this comment.
Very cool!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
|
cc @jordanlewis can you take a look at this? |
jordanlewis
reviewed
Mar 16, 2020
There was a problem hiding this comment.
Reviewable status:
|
bors r=jordanlewis |
Build failed (retrying...) |
Build failed |
The kvtrace logictest option now accepts parameters to filter the results by. These parameters include operation type and prefix the k/v's in the operation. This PR also a bulk of the secondary_index_column_families logictest to demonstrate the use of the new feature. Release justification: non-production code change Release note: None
|
bors r=jordanlewis |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kvtrace logictest option now accepts parameters
to filter the results by. These parameters include
operation type and prefix the k/v's in the operation.
This PR also a bulk of the secondary_index_column_families
logictest to demonstrate the use of the new feature.
Release justification: non-production code change
Release note: None