Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add ability to alter primary key of a new table #46015

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Mar 11, 2020

Fixes #46008.
Fixes #46007.

Release justification: low risk change that adds a useful feature

Release note (sql change): This PR makes it possible to create
a table and then add/alter primary key within the same transaction.

@rohany rohany requested a review from thoszhang March 11, 2020 23:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except please add tests for uninterleaving table in same txn as adding new pk.

Fixes cockroachdb#46008.
Fixes cockroachdb#46007.

Release justification: low risk change that adds a useful feature

Release note (sql change): This PR makes it possible to create
a table and then add/alter primary key within the same transaction.
@rohany
Copy link
Contributor Author

rohany commented Mar 16, 2020

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented Mar 16, 2020

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants