workload: fix rand generator #46573
Merged
workload: fix rand generator #46573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I haven't checked the pr but can we have a nightly test that uses this function so that we make sure it doesn't rot in the future? |
|
That would certainly be a nice thing to have. |
|
code LGTM, test would be nice. Not sure how we were allowed to be importing a testing package here. |
|
@jordanlewis I had to pull these changes into my other pr #46590 to get tests to pass, mind if I close this? |
|
Can you reopen this PR? I don't think my fix is getting in soon. If not, I'll just patch the changes. |
|
LGTM |
rohany
approved these changes
May 9, 2020
It had rotted. Also, add JSON datatype. Release note: None Release justification: test-only code change
|
bors r+ |
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had rotted. Also, add JSON datatype.
Closes #46569.