sqltelemetry: add CANCEL QUERIES and CANCEL SESSIONS telemetry #46778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
reviewed
Mar 31, 2020
There was a problem hiding this comment.
LGTM, but should we wait for #46730 to be addressed first?
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
Yes, I think so. |
yuzefovich
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
bors r=yuzefovich |
|
bors r=yuzefovich |
craig bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
46778: sqltelemetry: add CANCEL QUERIES and CANCEL SESSIONS telemetry r=yuzefovich a=asubiotto Release note: None (internal telemetry change) Closes #45103 Not sure whether we want to distinguish between CANCEL QUERY vs QUERIES use and CANCEL SESSION vs SESSIONS use (or even how to). So just added one counter for each statement type which is probably good enough. Tested this manually but holding off on writing tests since I've heard some work will be done on #46730 Co-authored-by: Alfonso Subiotto Marques <alfonso@cockroachlabs.com>
Release note: None (internal telemetry change)
|
Forgot about this one, it seems like bors canceled both times. Rebased and trying again. bors r=yuzefovich |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None (internal telemetry change)
Closes #45103
Not sure whether we want to distinguish between CANCEL QUERY vs QUERIES use and CANCEL SESSION vs SESSIONS use (or even how to). So just added one counter for each statement type which is probably good enough.
Tested this manually but holding off on writing tests since I've heard some work will be done on #46730