Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix sqlalchemy roachtest #47034

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Apr 4, 2020

This test was failing because an upstream change made the test
incompatible with the latest version of pytest.

It is fixed by pinning the version of pytest that gets installed. The
ignore list is also updated to deal with a test result parsing issue.

fixes #45989

Release note: None

@rafiss rafiss requested review from nvanbenschoten and apantel April 4, 2020 16:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Apr 6, 2020

thanks!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 6, 2020

Build failed

@rafiss
Copy link
Collaborator Author

rafiss commented Apr 7, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 7, 2020

Build failed (retrying...)

This test was failing because an upstream change made the test
incompatible with the latest version of pytest.

It is fixed by pinning the version of pytest that gets installed. The
ignore list is also updated to deal with a test result parsing issue.

Release note: None
@rafiss rafiss force-pushed the fix-sqlalchemy-roachtest branch from 1698ab8 to 3058d79 Compare April 8, 2020 14:53
@rafiss
Copy link
Collaborator Author

rafiss commented Apr 8, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 8, 2020

Build succeeded

@craig craig bot merged commit b2bd437 into cockroachdb:master Apr 8, 2020
@rafiss rafiss deleted the fix-sqlalchemy-roachtest branch April 27, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: sqlalchemy failed
3 participants