release-20.1: sql: ignore soft limits on scan nodes for distsql planning #47371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on 0ce5a11c. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
RaduBerinde
approved these changes
Apr 11, 2020
We have added propagation of soft limits in 20.1 release, and this causes some of the queries that used to run via DistSQL with `distsql=auto` to get a "should not distribute" recommendation during distsql physical planning. However, this can cause an egregious performance regression on some queries from 19.2 version. In order to keep the decision whether to distribute scans or not the same, we will be ignoring the soft limits on scan nodes for now. Release note: None
yuzefovich
force-pushed
the
backport20.1-47365
branch
from
0ce5a11
to
84a9f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47365.
/cc @cockroachdb/release
We have added propagation of soft limits in 20.1 release, and this
causes some of the queries that used to run via DistSQL with
distsql=autoto get a "should not distribute" recommendation duringdistsql physical planning. However, this can cause an egregious
performance regression on some queries from 19.2 version. In order to
keep the decision whether to distribute scans or not the same, we will
be ignoring the soft limits on scan nodes for now.
Addresses: #47058.
Release note: None