ui: CSS modules for Button component #48155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
koorosh
force-pushed
the
ui-css-modules--button
branch
from
265f68c
to
29f7a7b
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 29f7a7ba. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
23 tasks
koorosh
force-pushed
the
ui-css-modules--button
branch
from
29f7a7b
to
c77f131
Compare
This change refactors following components to use CSS modules instead of styles defined as global: - Dropdown - Search - PageConfig Release note: None
Release note: None
Release note: None
Following components are refactored to use CSS modules instead of global styles: - Statement Details page - Statements Diagnostics components - Anchor - Text - Empty Before, `Empty` component had styles which override Text, and Anchor components. Now, these styles are passed via `className` component props and custom styles defined by outer component. Release note: None
Statement Details pages has four tabs which aren't controlled and it wasn't possible to open particular tab and render it in storybook. It is also led to usability issue where selected tab was not preserved after page refresh. With current commit: - selected tab is tracked as search param in URL - added storybook for Statement Details page for every tab except Diagnostics tab. Content of Diagnostics tab is independent connected view and has to be defined in it's own storybook. Release note (admin ui change): preserve selected tab in Statement Details page after reload.
Instead of accessing to CSS modules class names as fields, `classnames/bind` function is used to bind class names to hashed names in imported CSS module file. Release note: None
Following components are refactored to use CSS modules instead of global styles: - Statement Details page - Statements Diagnostics components - Anchor - Text - Empty Before, `Empty` component had styles which override Text, and Anchor components. Now, these styles are passed via `className` component props and custom styles defined by outer component. Release note: None
Before, Button component had styles defined with own namespacing and now styles are imported as CSS module. The main change is separation BackIcon component which was coupled with Button and the way custom styles were applied to display button as a link without highlighting. - BackIcon is refactored to it's own module with styles - custom styles are applied with new Button type option - `unstyled-link`. Release note: None
koorosh
force-pushed
the
ui-css-modules--button
branch
from
c77f131
to
2ae1cca
Compare
dhartunian
approved these changes
Jun 9, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #48090
Related to #47527
Before, Button component had styles defined with
own namespacing and now styles are imported as
CSS module.
The main change is separation BackIcon component
which was coupled with Button and the way
custom styles were applied to display button as
a link without highlighting.
styles
option -
unstyled-link.Release note: None