Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage,libroach: Check for MaxKeys when reading from intent history #48160

Merged
merged 1 commit into from
Apr 29, 2020
Merged

storage,libroach: Check for MaxKeys when reading from intent history #48160

merged 1 commit into from
Apr 29, 2020

Commits on Apr 29, 2020

  1. storage,libroach: Check for MaxKeys when reading from intent history 

    We weren't checking for MaxKeys (or TargetBytes) being reached
in the case where we read from intent history in the MVCC scanner.
All other cases go through addAndAdvance(), which had these checks.

Almost certainly fixes cockroachdb#46652. Would be very surprised if it was
something else.

Release note (bug fix): Fixes a bug where a read operation in a transaction
would error out for exceeding the maximum count of results returned.
    @itsbilal
    itsbilal committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    3628ed9 View commit details
    Browse the repository at this point in the history