Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: CSS modules for Badge component #48234

Merged
merged 10 commits into from
Jun 9, 2020
Merged

ui: CSS modules for Badge component #48234

merged 10 commits into from
Jun 9, 2020

Commits on Jun 9, 2020

  1. ui: CSS modules for Statements page filters 

    This change refactors following components to
use CSS modules instead of styles defined as
global:
- Dropdown
- Search
- PageConfig

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    8677bc0 View commit details
    Browse the repository at this point in the history

  2. ui: CSS modules for SummaryCard component 

    Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d169567 View commit details
    Browse the repository at this point in the history

  3. ui: CSS modules for Tooltip shared component 

    Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    08daedd View commit details
    Browse the repository at this point in the history

  4. ui: CSS modules for Statement Details page 

    Following components are refactored to use CSS modules
 instead of global styles:
- Statement Details page
- Statements Diagnostics components
- Anchor
- Text
- Empty

Before, `Empty` component had styles which override
 Text, and Anchor components. Now, these styles are
 passed via `className` component props and custom
 styles defined by outer component.

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    24b91a8 View commit details
    Browse the repository at this point in the history

  5. ui: Storybook for Statements Details page 

    Statement Details pages has four tabs which aren't
controlled and it wasn't possible to open particular
tab and render it in storybook. It is also led to
usability issue where selected tab was not preserved
after page refresh.

With current commit:
- selected tab is tracked as search param in URL
- added storybook for Statement Details page for
every tab except Diagnostics tab.
Content of Diagnostics tab is independent connected
view and has to be defined in it's own storybook.

Release note (admin ui change): preserve selected tab in Statement
Details page after reload.
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    5b2fff5 View commit details
    Browse the repository at this point in the history

  6. ui: Bind CSS class names with classnames/bind 

    Instead of accessing to CSS modules class names as fields,
`classnames/bind` function is used to bind class names to
hashed names in imported CSS module file.

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    87f78ee View commit details
    Browse the repository at this point in the history

  7. ui: CSS modules for Statement Details page 

    Following components are refactored to use CSS modules
 instead of global styles:
- Statement Details page
- Statements Diagnostics components
- Anchor
- Text
- Empty

Before, `Empty` component had styles which override
 Text, and Anchor components. Now, these styles are
 passed via `className` component props and custom
 styles defined by outer component.

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    f9d718d View commit details
    Browse the repository at this point in the history

  8. ui: CSS modules for Button component 

    Before, Button component had styles defined with
own namespacing and now styles are imported as
CSS module.

The main change is separation BackIcon component
which was coupled with Button and the way
custom styles were applied to display button as
a link without highlighting.

- BackIcon is refactored to it's own module with
styles
- custom styles are applied with new Button type
option - `unstyled-link`.

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    2ae1cca View commit details
    Browse the repository at this point in the history

  9. ui: CSS modules for SqlBox components 

    Refactor following components to use
CSS modules instead of global styles:
- SqlBox
- highlight

Note, `hljs-` classes are 3rd-party
styles which are overriden with custom
styles.

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    249db86 View commit details
    Browse the repository at this point in the history

  10. ui: CSS modules for Badge component 

    Define styles for Badge component as
CSS modules.

Release note: None
    @koorosh
    koorosh committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    49cd4a3 View commit details
    Browse the repository at this point in the history