opt: update stats quality tests with multi-column stats #48374
Merged
+289
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the injected stats for the TPC-C and TPC-H stats quality tests to include multi-column stats. Since multi-column stats are currently only used by the optimizer in a few limited cases, none of the plans changed. This commit is in preparation for work that will be done in the optimizer to use multi-column stats for selectivity estimation. Informs cockroachdb#34422 Release note: None
|
This change is |
RaduBerinde
approved these changes
May 5, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the injected stats for the TPC-C and TPC-H stats
quality tests to include multi-column stats. Since multi-column stats
are currently only used by the optimizer in a few limited cases, none
of the plans changed.
This commit is in preparation for work that will be done in the optimizer
to use multi-column stats for selectivity estimation.
Informs #34422
Release note: None