cli: limit flag for debug range-data / debug keys #49290
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @tbg)
pkg/cli/debug.go, line 304 at r1 (raw file):
defer iter.Close() for i := 0; ; iter.Next() { i++
[nit] Move the i declaration outside the for loop block, s/i/results, and move results++ closer to the limit check (similar to what we now have for runDebugKeys).
andreimatei
force-pushed
the
misc.dump-limit
branch
from
1e4c5c8
to
0dc131e
Compare
| @@ -105,7 +105,6 @@ func initCLIDefaults() { | |||
| debugCtx.replicated = false | |||
| debugCtx.inputFile = "" | |||
| debugCtx.printSystemConfig = false | |||
| debugCtx.maxResults = 1000 | |||
There was a problem hiding this comment.
Keep this line; it's needed. You can change the value to zero.
pkg/cli/flags.go
Outdated
| @@ -697,12 +697,14 @@ func init() { | |||
| f := debugKeysCmd.Flags() | |||
| VarFlag(f, (*mvccKey)(&debugCtx.startKey), cliflags.From) | |||
| VarFlag(f, (*mvccKey)(&debugCtx.endKey), cliflags.To) | |||
| IntFlag(f, &debugCtx.maxResults, cliflags.Limit, 0) | |||
There was a problem hiding this comment.
last arg is debugCtx.maxResults, not 0
pkg/cli/flags.go
Outdated
| BoolFlag(f, &debugCtx.values, cliflags.Values, debugCtx.values) | ||
| BoolFlag(f, &debugCtx.sizes, cliflags.Sizes, debugCtx.sizes) | ||
| } | ||
| { | ||
| f := debugRangeDataCmd.Flags() | ||
| BoolFlag(f, &debugCtx.replicated, cliflags.Replicated, debugCtx.replicated) | ||
| IntFlag(f, &debugCtx.maxResults, cliflags.Limit, 0) |
andreimatei
force-pushed
the
misc.dump-limit
branch
from
0dc131e
to
cf90575
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3.
Reviewable status:
pkg/cli/flags.go, line 700 at r2 (raw file):
Previously, knz (kena) wrote…
last arg is
debugCtx.maxResults, not0
that still needs to change (we don't want to reproduce defaults in multiple places)
pkg/cli/flags.go, line 707 at r2 (raw file):
Previously, knz (kena) wrote…
ditto
ditto
There was a teasing maxResults field already, completely unused. Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/cli/debug.go, line 304 at r1 (raw file):
Previously, irfansharif (irfan sharif) wrote…
[nit] Move the
ideclaration outside the for loop block, s/i/results, and moveresults++closer to the limit check (similar to what we now have forrunDebugKeys).
done
pkg/cli/flags.go, line 700 at r2 (raw file):
Previously, knz (kena) wrote…
that still needs to change (we don't want to reproduce defaults in multiple places)
Done.
pkg/cli/flags.go, line 707 at r2 (raw file):
Previously, knz (kena) wrote…
ditto
Done.
andreimatei
force-pushed
the
misc.dump-limit
branch
from
cf90575
to
84681dd
Compare
There was a problem hiding this comment.
bors r+
Reviewable status:
Build succeeded |
There was a teasing maxResults field already, completely unused.
Release note: None