Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade base image to deployment dockerfile #49593

Merged
merged 1 commit into from
Jun 1, 2020
Merged

build: Upgrade base image to deployment dockerfile #49593

merged 1 commit into from
Jun 1, 2020

Conversation

bobvawter
Copy link
Member

This change updates the deployment base image from Debian 9.8 to 9.12.

Fixes: #41390

Release note (build change): Release Docker images are now built on
Debian 9.12.

This change updates the deployment base image from Debian 9.8 to 9.12.

Fixes: #41390

Release note (build change): Release Docker images are now built on
Debian 9.12.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bobvawter
Copy link
Member Author

@bdarnell I've smoke-tested the resulting image build; are there any other specific tests I should run before committing this?

@bdarnell
Copy link
Contributor

For 20.2, we don't want to just upgrade to a newer debian, we want to use redhat's UBI as the base image. (although if you're thinking about backporting to current releases a newer debian would be the way to go).

For updating to a newer version of debian, basic smoke testing is probably fine. For the switch to redhat the things to check are:

  • backup to a public cloud (verifying the presence of root CA certs)
  • run queries involving time zones specified as location names (verifying the presence of tzdata)
  • run an interactive shell in a terminal and use arrow keys for history, etc (verifying the presence of terminfo)

@bobvawter
Copy link
Member Author

I've filed #49643 about adding a UBI-based image in addition to our Debian base. What I'd like to do is to go ahead and commit this, then backport to 20.1, 19.2, and 19.1 branches so that operators will at least get refreshed images.

@bobvawter
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 28, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented May 28, 2020

Build failed

@bobvawter
Copy link
Member Author

bors retry

@craig
Copy link
Contributor

craig bot commented Jun 1, 2020

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container base image needs to be updated
3 participants