Commits on Jun 1, 2020

1. rowcontainer,rowexec: switch joinReader to use DiskBackedNumberedRowC… …

   …ontainer
   
   Additionally,
   - added a randomized correctness test that compares the results of the indexed
     and numbered containers.
   - added benchmark cases to the joinReader benchmark that limit memory. None of
     the workloads have repeated reads of the same right row and all access the
     right rows in monotonically increasing order so the difference between the
     two containers is due to the numbered container avoiding the overhead of
     populating the cache.
   - reduced the number of allocations in newNumberedDiskRowIterator.
     - the accesses slices share the same underlying slice.
     - a row copy, when there is a miss and the row is not added to the cache, is
       eliminated. When a copy is needed and we have evicted a row from the cache,
       the copying reuses that evicted row.
     - allocations of the map, map elements are reused.
   
   Fixes cockroachdb#48118
   
   Release note: None

   

   sumeerbhola committed Jun 1, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for f39ae24
   • Browse repository at this point

   Copy the full SHA

   f39ae24 View commit details

   Browse the repository at this point in the history