lease: fix flakey TestRangefeedUpdatesHandledProperlyInTheFaceOfRaces #49681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
When this test was introduced, the cluster version override was added to ensure that rangefeeds would be used. This was not necessary given the other testing knob which this change adopts. The problem with overrriding the version is that it can happen after the automatic version upgrade already occurs leading to a fatal error due to trying to downgrade the cluster version. Fixes cockroachdb#49632. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-flakey-test-due-to-version-upgrade
branch
from
6b873f9
to
5e33b5c
Compare
thoszhang
approved these changes
May 29, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this test was introduced, the cluster version override was added to
ensure that rangefeeds would be used. This was not necessary given the
other testing knob which this change adopts. The problem with overrriding
the version is that it can happen after the automatic version upgrade already
occurs leading to a fatal error due to trying to downgrade the cluster
version.
Release note: None