geo/geomfn: use GEOSRelatePattern for ST_ContainsProperly #49759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
contains_properly_faster
branch
from
41557d8
to
4aa4b43
Compare
sumeerbhola
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/geo/geomfn/de9im.go, line 28 at r1 (raw file):
} // RelatePattern returns the whether the DE-9IM relation between A and B matches.
... returns whether the ... matches the pattern.
otan
commented
Jun 2, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/geo/geomfn/de9im.go, line 28 at r1 (raw file):
Previously, sumeerbhola wrote…
... returns whether the ... matches the pattern.
Done.
otan
force-pushed
the
contains_properly_faster
branch
from
4aa4b43
to
fc9de31
Compare
GEOSRelatePattern seems to avoid the checks for wildcards, making ST_ContainsProperly faster. Release note: None
otan
force-pushed
the
contains_properly_faster
branch
from
fc9de31
to
26d5952
Compare
|
bors r=sumeerbhola |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOSRelatePattern seems to avoid the checks for wildcards, making
ST_ContainsProperly faster.
Release note: None