Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: add support for bit and some arithmetic binary operators #49761

Merged
merged 2 commits into from
Jun 5, 2020
Merged

colexec: add support for bit and some arithmetic binary operators #49761

merged 2 commits into from
Jun 5, 2020

Commits on Jun 5, 2020

  1. sem: unify division by zero check and fix it in a few places 

    Release note (bug fix): Previously, in some cases, CockroachDB didn't
check whether the right argument of `Div` (`/`), `FloorDiv` (`//`),
or `Mod` (`%`) operations was zero, so instead of correctly returning
a "division by zero" error, we were returning `NaN`, and this is now
fixed. Additionally, the error message of "modulus by zero" has been
changed to "division by zero" to be inline with Postgres.
    @yuzefovich
    yuzefovich committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    b973a82 View commit details
    Browse the repository at this point in the history

  2. colexec: add support for bit and some arithmetic binary operators 

    This commit adds support for `Bitand`, `Bitor`, `Bitxor`, `FloorDiv`,
and `Mod` binary operators for both native and datum-backed types.

Release note (sql change): Vectorized execution engine now supports
`Bitand` (`&`), `Bitor` (`|`), `Bitxor` (`^`), `FloorDiv` (`//`), and
`Mod` (`%`) binary operators.
    @yuzefovich
    yuzefovich committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    ca6c664 View commit details
    Browse the repository at this point in the history