sql/physicalplan: small refactor #49769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch lifts the concern about consistently resolving spans from a single range to the same node up to the spanResolver, from one of the replica oracles. Regardless of what oracle is used (i.e. the lease-holder aware one, or the follower-reads one), making a single node in charge of all the spans that fall within one range seems like a good idea. Currently only the leaseholder oracle was doing this. This makes SpanResolver.ReplicaInfo() idempotent. Release note: None
We were sleeping to deal with range cache clobbering, but we no longer have these clobbering problems since cache updates are now resistant to stale information overwiting newer one. Release note: None
|
This change is |
ajwerner
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
andreimatei
commented
Jun 1, 2020
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch lifts the concern about consistently resolving spans from a
single range to the same node up to the spanResolver, from one of the
replica oracles. Regardless of what oracle is used (i.e. the
lease-holder aware one, or the follower-reads one), making a single node
in charge of all the spans that fall within one range seems like a good
idea. Currently only the leaseholder oracle was doing this.
This makes SpanResolver.ReplicaInfo() idempotent.