sql: add the crdb_internal.create_type_statements table
#49771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This PR adds the `crdb_internal.create_type_statments` table, which contains create statements for user defined types. This will be used when generating create statments for `cockroach dump` in cockroachdb#47765. This PR additionally refactors and deduplicates some code that iterates over all user defined type descriptors in other virtual tables. Release note (sql change): Add the `crdb_internal.create_type_statements` virtual table. It holds create statements for user defined types.
otan
approved these changes
Jun 2, 2020
| statement ok | ||
| SET experimental_enable_enums=true; | ||
| CREATE TYPE enum1 AS ENUM ('hello', 'hi'); | ||
| CREATE TYPE enum2 AS ENUM () |
There was a problem hiding this comment.
can you try one with an enum value inserted in between?
There was a problem hiding this comment.
Sorry, what do you mean?
There was a problem hiding this comment.
ALTER TYPE enum1 ADD VALUE 'interjection!' AFTER 'hello'
There was a problem hiding this comment.
lol we don't support alter type yet. I'll go back and add cases for that everywhere once we do.
|
bors r=otan |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
crdb_internal.create_type_statmentstable, whichcontains create statements for user defined types. This will be used
when generating create statments for
cockroach dumpin #47765.This PR additionally refactors and deduplicates some code that iterates
over all user defined type descriptors in other virtual tables.
Release note (sql change): Add the
crdb_internal.create_type_statementsvirtual table. It holds createstatements for user defined types.