colexec: add JSONFetchVal operator for vectorized engine

[yongyanglai]

Previously, the vectorized engine had no support for JSONFetchVal
operator. This commit added JSONFetchVal operator.
In this commit, I added BytesFamily into compatible canonical type
family group of DatumVecCanonicalTypeFamily. Then I declared
JSONFetchVal as supported binary operator and registered output
type of JSONFetchVal to generate operators.

Fixes #49469

Release note (sql change): Vectorized engine now supports JSONFetchVal(->) operator.

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

• Please ensure your pull request description contains a release note - this can be the same as the one in your commit message.
• When CI has completed, please ensure no errors have appeared.

I have added a few people who may be able to assist in reviewing:

• @yuzefovich (author of colexec: add support for JSONFetchVal binary operator #49469)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[yuzefovich]

Thanks for working on this!

nit: in the commit message, s/Previvously/Previously/g.

Reviewed 3 of 3 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @yongyanglai)

---

pkg/sql/colexec/execgen/cmd/execgen/overloads_bin.go, line 165 at r1 (raw file):

	binOpOutputTypes[tree.JSONFetchVal] = map[typePair]*types.T{
		{typeconv.DatumVecCanonicalTypeFamily, anyWidth, types.IntFamily, anyWidth}:   types.Any,

types.IntFamily supports multiple widths and we should set the output type for each, look for an example above in this function.

---

pkg/sql/colexec/execgen/cmd/execgen/overloads_bin.go, line 649 at r1 (raw file):

		runtimeConversion = fmt.Sprintf("tree.DInterval{Duration: %s}", nativeElem)
	case types.BytesFamily:
		switch op {

This works for now, but we probably need to figure out a better way to do this type resolution. Could you please add this TODO to the code?

// TODO(yuzefovich): figure out a better way to perform type resolution
// for types that have the same physical representation.

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[yongyanglai]

Thanks for reviews.
RFAL

[yuzefovich]

Thanks! Last two nits and then it is good to go.

Reviewed 1 of 1 files at r2.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @yongyanglai)

---

pkg/sql/colexec/execgen/cmd/execgen/overloads_bin.go, line 167 at r2 (raw file):

		{typeconv.DatumVecCanonicalTypeFamily, anyWidth, types.BytesFamily, anyWidth}: types.Any,
	}
	for _, leftIntWidth := range supportedWidthsByCanonicalTypeFamily[types.IntFamily] {

nit: I'd name it simply intWidth because we have IntFamily only on one side.

---

pkg/sql/logictest/testdata/logic_test/vectorize_overloads, line 240 at r2 (raw file):

query T
EXPLAIN (VEC) SELECT _json -> 0 FROM many_types

nit: it would be nice to try non-constant on the right, maybe SELECT _json -> _int2 FROM many_types?

[yongyanglai]

Thanks, I have added more logic test
PTAL

[yuzefovich]

Thanks!

We're currently experiencing some issues with our CI system, and I will merge this PR once those are resolved.

Reviewed 2 of 2 files at r3.
Reviewable status: complete! 1 of 0 LGTMs obtained

[yuzefovich]

Thanks for your contribution!

bors r=yuzefovich

[craig]

Build succeeded

• GitHub CI (Cockroach)