Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhance the contributor guide #49837

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 3, 2020

The contributor guide only contained a URL to the wiki, and was
missing searchable keywords.

This patch adds that, as well as a link to the community slack.

Release note: None

@knz knz requested review from dt and otan June 3, 2020 17:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit + optional nits; otherwise LGTM!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@knz
Copy link
Contributor Author

knz commented Jun 3, 2020

thanks

bors r=otan

@knz
Copy link
Contributor Author

knz commented Jun 3, 2020

bors r-

@craig
Copy link
Contributor

craig bot commented Jun 3, 2020

Canceled

The contributor guide only contained a URL to the wiki, but was
missing searchable keywords.

This patch adds that, as well as a link to the community slack.

Release note: None
@knz
Copy link
Contributor Author

knz commented Jun 3, 2020

bors r=otan

@craig
Copy link
Contributor

craig bot commented Jun 3, 2020

Canceled

@knz
Copy link
Contributor Author

knz commented Jun 3, 2020

bors r=otan

@craig
Copy link
Contributor

craig bot commented Jun 3, 2020

Build succeeded

@craig craig bot merged commit d8d001b into cockroachdb:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants