sql: tag skipped test with issue #49844
Conversation
Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @asubiotto)
pkg/sql/distsql_physical_planner_test.go, line 432 at r1 (raw file):
defer leaktest.AfterTest(t)() t.Skip("#49843. test is too slow; we need to tweak timeouts so connections die faster (see #14376)")
This test was skipped in 2017, is this still true? Maybe the introduction of circuitbreakers (with possible tweaking) makes this test faster.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/distsql_physical_planner_test.go, line 432 at r1 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
This test was skipped in 2017, is this still true? Maybe the introduction of circuitbreakers (with possible tweaking) makes this test faster.
could well be, but I'd rather let you figure it out :)
There was a problem hiding this comment.
Reviewable status:
|
Bors r+
…On Fri, Jun 5, 2020, 5:10 AM Alfonso Subiotto Marqués < ***@***.***> wrote:
***@***.**** approved this pull request.
[image: <img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/>]
<https://camo.githubusercontent.com/41b3ec3419116e3b3f84507ad965646ce4ce1f0c/68747470733a2f2f72657669657761626c652e696f2f6c67746d2e706e67>
*Reviewable
<https://reviewable.io/reviews/cockroachdb/cockroach/49844#-:-M92jfbN5vYHg3BhbZr1:bg7igkv>*
status: [image:
] complete! 1 of 0 LGTMs obtained (waiting on
@asubiotto <https://github.com/asubiotto>)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#49844 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4POTSWDQIIG2HOKMRLRVCZAZANCNFSM4NR7O7CQ>
.
|
Build succeeded |
Release note: None