Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Remove extra vars from runExportToSst #49852

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

itsbilal
Copy link
Member

@itsbilal itsbilal commented Jun 3, 2020

A previous change (#49721) adding a benchmark for ExportToSst
left in some extra unused variables in a helper method. This
change cleans that up.

Release note: None.

@itsbilal itsbilal self-assigned this Jun 3, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsbilal
Copy link
Member Author

itsbilal commented Jun 3, 2020

No change amend to get CI to build.

A previous change (cockroachdb#49721) adding a benchmark for ExportToSst
left in some extra unused variables in a helper method. This
change cleans that up.

Release note: None.
@itsbilal
Copy link
Member Author

itsbilal commented Jun 8, 2020

Only test failure is #49747 .

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Build succeeded

@craig craig bot merged commit 685194e into cockroachdb:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants