Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo: handle maximum decimal digits for ST_AsText #49875

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Jun 4, 2020

Resolves #48387.
Resolves #48885.

Release note (sql change): Introduce maxDecimalDigits arguments for
ST_AsText and ST_AsEWKT, which allow rounding of the decimal digits
output in the WKT representation.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan marked this pull request as ready for review June 4, 2020 21:21
@otan otan requested review from sumeerbhola and a team June 4, 2020 21:22
@otan otan force-pushed the go-geom-update branch 2 times, most recently from 36e35f2 to b5a8b63 Compare June 5, 2020 23:47
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Contributor Author

otan commented Jun 8, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

1 similar comment
@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@otan
Copy link
Contributor Author

otan commented Jun 8, 2020

bors r-

VENDORING IS THE WORST

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Canceled

@otan
Copy link
Contributor Author

otan commented Jun 8, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

1 similar comment
@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@otan
Copy link
Contributor Author

otan commented Jun 8, 2020

bors r-

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Canceled

Release note (sql change): Introduce maxDecimalDigits arguments for
ST_AsText and ST_AsEWKT, which allow rounding of the decimal digits
output in the WKT representation.
@otan
Copy link
Contributor Author

otan commented Jun 9, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Jun 9, 2020

Build succeeded

@craig craig bot merged commit 3e74b0d into cockroachdb:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_AsText({geometry,int4}) geo/geogfn: implement ST_AsText({geography,int4})
3 participants