Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: enable adding check constraints that use enums #49945

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Jun 7, 2020

Work for #48728.

This PR ensures that check constraints that use enums can be added and
validated. It also updates the sites where check validations fail to
ensure that the displayed error message has been deserialized from the
internal representation.

Release note: None

Work for cockroachdb#48728.

This PR ensures that check constraints that use enums can be added and
validated. It also updates the sites where check validations fail to
ensure that the displayed error message has been deserialized from the
internal representation.

Release note: None
@rohany rohany requested review from jordanlewis and otan June 7, 2020 02:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how easily digestible these PRs are!

@rohany
Copy link
Contributor Author

rohany commented Jun 7, 2020

Ty -- its much easier now that all the heavy lifting is done.

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented Jun 7, 2020

Build succeeded

@craig craig bot merged commit 2da8b25 into cockroachdb:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants