Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: introduce new configs for experimental distsql planning #50249

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jun 15, 2020

This commit adds three new configurations local-exp-planning,
fakedist-exp-planning, and 5node-exp-planning which override
experimental_distsql_planning cluster setting to on. The
corresponding config is included in 5node-defaults list. And once
the new factory is significantly implemented, it will probably make
sense to add the configs to default-configs.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @yuzefovich)


pkg/sql/logictest/logic.go, line 482 at r1 (raw file):

	},
	{
		name:                                "local-exp-planning",

exp sounds like expression to me. How about spece.g.local-spec-planning` instead?


pkg/sql/logictest/logic.go, line 586 at r1 (raw file):

	},
	{
		name:                                "5node-exp-planning",

What if we add this to the 5node-defaults directive? Is it worth it?

This commit adds three new configurations `local-exp-planning`,
`fakedist-exp-planning`, and `5node-exp-planning` which override
`experimental_distsql_planning` cluster setting to `on`. The
corresponding config is included in `5node-defaults` list. And once
the new factory is significantly implemented, it will probably make
sense to add the configs to `default-configs`.

Release note: None
Copy link
Member Author

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @asubiotto)


pkg/sql/logictest/logic.go, line 482 at r1 (raw file):

Previously, asubiotto (Alfonso Subiotto Marqués) wrote…

exp sounds like expression to me. How about spece.g.local-spec-planning` instead?

I like this suggestion, done.


pkg/sql/logictest/logic.go, line 586 at r1 (raw file):

Previously, asubiotto (Alfonso Subiotto Marqués) wrote…

What if we add this to the 5node-defaults directive? Is it worth it?

Hm, at this point not many things are implemented in the new factory, so most of the work will be redundant. However, we use 5node-defaults in about 10 files, so it shouldn't make the test time a lot worse, and it might be nice to have the new config in those files. Done.

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 16, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Jun 17, 2020

Build succeeded

@craig craig bot merged commit bb4bf85 into cockroachdb:master Jun 17, 2020
@yuzefovich yuzefovich deleted the distsql-logic branch June 17, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants