Commits on Jun 17, 2020

1. server: Wrap ExternalStorage factory methods in externalStorageBuilde… …

   …r struct
   
   Previously, we initialized the ExternalStorage factory methods on
   creation of a NewServer() as all the required config params were
   ready-to-use.
   
   With future work related to user scoped storage requiring access to the
   underlying storage.Engine, this change introduces a wrapper around these
   factory methods. Using a builder struct allows us to split the
   "creation" and "initialization" of the builder between the NewServer()
   and Start() methods respectively. This allows for params which are only
   initialized on server.Start() to be propogated to the builder for future
   use.
   
   This is part of a gradual refactor of the ExternalStorage factory
   interface and is primarily to unblock development of cockroachdb#47211.
   
   Release note: None

   

   adityamaru committed Jun 17, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for c3b8bcd
   • Browse repository at this point

   Copy the full SHA

   c3b8bcd View commit details

   Browse the repository at this point in the history