Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.1: errorutil/unimplemented: use redirect server for Github links #50310

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jun 16, 2020

Backport 1/1 commits from #49836.

/cc @cockroachdb/release


closes #45504

This will allow us to capture telemetry such as click counts for each
unimplemented error that is returned.

Release note (general change): Links that are returned in error messages
to point to unimplemented issues now use the CockroachLabs
redirect/short-link server.

This will allow us to capture telemetry such as click counts for each
unimplemented error that is returned.

Release note (general change): Links that are returned in error messages
to point to unimplemented issues now use the CockroachLabs
redirect/short-link server.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from jordanlewis June 16, 2020 23:45
Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafiss rafiss merged commit 8e58aa7 into cockroachdb:release-20.1 Jun 24, 2020
@rafiss rafiss deleted the backport20.1-49836 branch June 24, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants