sql: disable arrays in forward indexes #50662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
reviewed
Jun 25, 2020
| CREATE INDEX i ON t(x DESC) | ||
|
|
||
| # Add "t@i" index annotation once #50659 is fixed. |
There was a problem hiding this comment.
Can you leave a TODO and a name here?
There was a problem hiding this comment.
Added a TODO above.
|
LGTM |
sumeerbhola
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mjibson, @rohany, and @sumeerbhola)
|
Had to track down some test flakes due to our rand table functions (including random interleaving and random FKs not using the indexable function). Fixed those and will merge once tests pass again. |
|
bors r+ |
Build succeeded |
|
@sumeerbhola @solongordon do you know exactly why we needed to do this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some open questions about inverted index types being used in
forward indexes. Disable those for now.
Fixes #50656
See #50659
See #17154
Release note (sql change): disable arrays in non-inverted indexes.