Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt, cat: rename Table.AllColumnCount to Table.ColumnCount #51489

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

RaduBerinde
Copy link
Member

This change renames AllColumnCount to ColumnCount. In #51400 I meant
to rename before merging but I forgot.

Release note: None

This change renames AllColumnCount to ColumnCount. In cockroachdb#51400 I meant
to rename before merging but I forgot.

Release note: None
@RaduBerinde RaduBerinde requested a review from a team as a code owner July 15, 2020 23:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@andy-kimball andy-kimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball and @rohany)

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 16, 2020

Build succeeded

@craig craig bot merged commit 3fba3b9 into cockroachdb:master Jul 16, 2020
@RaduBerinde RaduBerinde deleted the column-count-api-rename branch July 18, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants