Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builkio: Add schedule control statements. #51896

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

miretskiy
Copy link
Contributor

Informs #51600

Introduce schedule control statements responsible for
managing scheduled jobs.

PAUSE SCHEDULE 123
PAUSE SCHEDULES SELECT ...

RESUME SCHEDULES SELECT schedule_id FROM system.schedules_jobs ...

DROP SCHEDULE 123

Release Notes (enterprise): Implement schedule control statements
to pause, resume, or delete scheduled jobs.

@miretskiy miretskiy requested review from dt, pbardea and a team July 25, 2020 00:40
@miretskiy miretskiy requested a review from a team as a code owner July 25, 2020 00:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt part LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dt and @pbardea)

Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 32 of 32 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dt and @miretskiy)


pkg/sql/opt/exec/factory.go, line 582 at r1 (raw file):

	// ConstructControlSchedules creates a node that implements PAUSE/CANCEL/RESUME
	// JOBS.

PAUSE/CANCEL/RESUME JOBS -> PAUSE/CANCEL/RESUME SCHEDULES


pkg/sql/opt/exec/execbuilder/statement.go, line 242 at r1 (raw file):

		return execPlan{}, err
	}
	// ControlJobs returns no columns.

ControlSchedules returns no columns?

Copy link
Contributor Author

@miretskiy miretskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dt and @pbardea)


pkg/sql/opt/exec/factory.go, line 582 at r1 (raw file):

Previously, pbardea (Paul Bardea) wrote…

PAUSE/CANCEL/RESUME JOBS -> PAUSE/CANCEL/RESUME SCHEDULES

Done.


pkg/sql/opt/exec/execbuilder/statement.go, line 242 at r1 (raw file):

Previously, pbardea (Paul Bardea) wrote…

ControlSchedules returns no columns?

Done.

Introduce schedule control statements responsible for
managing scheduled jobs.

```
PAUSE SCHEDULE 123
PAUSE SCHEDULES SELECT ...

RESUME SCHEDULES SELECT schedule_id FROM system.schedules_jobs ...

DROP SCHEDULE 123
```

Release Notes (enterprise): Implement schedule control statements
to pause, resume, or delete scheduled jobs.
@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 27, 2020

Build succeeded:

@craig craig bot merged commit 2c6d0d2 into cockroachdb:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants