-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builkio: Add schedule control statements. #51896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opt part LGTM
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @dt and @pbardea)
2004ec1
to
59f1434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 32 of 32 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @dt and @miretskiy)
pkg/sql/opt/exec/factory.go, line 582 at r1 (raw file):
// ConstructControlSchedules creates a node that implements PAUSE/CANCEL/RESUME // JOBS.
PAUSE/CANCEL/RESUME JOBS
-> PAUSE/CANCEL/RESUME SCHEDULES
pkg/sql/opt/exec/execbuilder/statement.go, line 242 at r1 (raw file):
return execPlan{}, err } // ControlJobs returns no columns.
ControlSchedules
returns no columns?
59f1434
to
bcb2b51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @dt and @pbardea)
pkg/sql/opt/exec/factory.go, line 582 at r1 (raw file):
Previously, pbardea (Paul Bardea) wrote…
PAUSE/CANCEL/RESUME JOBS
->PAUSE/CANCEL/RESUME SCHEDULES
Done.
pkg/sql/opt/exec/execbuilder/statement.go, line 242 at r1 (raw file):
Previously, pbardea (Paul Bardea) wrote…
ControlSchedules
returns no columns?
Done.
Introduce schedule control statements responsible for managing scheduled jobs. ``` PAUSE SCHEDULE 123 PAUSE SCHEDULES SELECT ... RESUME SCHEDULES SELECT schedule_id FROM system.schedules_jobs ... DROP SCHEDULE 123 ``` Release Notes (enterprise): Implement schedule control statements to pause, resume, or delete scheduled jobs.
bcb2b51
to
3a2fe46
Compare
bors r+ |
Build succeeded: |
Informs #51600
Introduce schedule control statements responsible for
managing scheduled jobs.
Release Notes (enterprise): Implement schedule control statements
to pause, resume, or delete scheduled jobs.