Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: use StatementsPage from admin-ui-components #51910

Merged
merged 3 commits into from
Aug 5, 2020
Merged

ui: use StatementsPage from admin-ui-components #51910

merged 3 commits into from
Aug 5, 2020

Commits on Aug 4, 2020

  1. ui: Add analytics tracking sagas on user actions 

    Previously, analytics functions (which track user interaction) were
called directly from React components that made these functionality
tightly coupled.

Now, sagas used to watch actions related to user interaction and then
call async logic in sagas.
- components expose only callback functions which is related to the
logic component is responsible;
- connected component is responsible to dispatch actions with proper
payload to be properly then handled by sagas.

Release note: none
    @koorosh
    koorosh committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5318058 View commit details
    Browse the repository at this point in the history

  2. ui: use StatementsPage from admin-ui-components 

    - Replace statementsPage component with extracted version
from `admin-ui-component` package.
- Provide correct props bindings to connected components,
because changed logic of calling analytics tracking functionality.

Release note: none
    @koorosh
    koorosh committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    d7fa3bb View commit details
    Browse the repository at this point in the history

  3. ui: Refactor trackTableSort analytics service usage 

    Initially, trackTableSort service was called directly from
React components and had an issue with correct tracking of
column names because `title` field has ReactNode type and
cannot be casted to String type for analytics payload.

With current change:
- trackTableSort service doesn't depend on interfaces defined on
representation level (decouples usage of service)
- trackTableSort service is called via sagas by watching appropriate
actions (again decouples service and representation layer)

Release note: None
    @koorosh
    koorosh committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    b816b22 View commit details
    Browse the repository at this point in the history