sqlbase,catalogkv: move more kv interactions to catalogkv #52486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajwerner
requested review from
thoszhang,
rohany,
a team and
pbardea
and removed request for
a team
|
This change is |
rohany
approved these changes
Aug 6, 2020
thoszhang
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Reviewed 29 of 29 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @pbardea and @rohany)
ajwerner
changed the title
At this point the only remaining kv interactions in sqlbase are during type and table interactions though there are also usages through the protoGetter. This is a minor change in the work to pick apart sqlbase. Release note: None
ajwerner
force-pushed
the
ajwerner/move-more-kv-interactions-to-catalogkv
branch
from
6aa119e
to
494074a
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point the only remaining kv interactions in sqlbase are during type
and table interactions though there are also usages through the protoGetter.
This is a minor change in the work to pick apart sqlbase.
Release note: None