sql: gate certain box2d comparison ops by a cluster setting #52990
Conversation
|
This change is |
otan
force-pushed
the
version_gate_operators
branch
4 times, most recently
from
6724b46 to
c4833a6
Compare
There was a problem hiding this comment.
Do you think it's worth also adding a session setting?
Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
i tried that initially -- the session setting doesn't help if the parameter operates on a remote processor AFAICT. |
otan
force-pushed
the
version_gate_operators
branch
from
c4833a6 to
6a57f01
Compare
|
Did you mean to increment the server version here? Or was that meant for another PR?
That's surprising... but I don't know enough about how these settings are passed around so I'll take your word for it. The cluster setting is more important anyway. |
|
oops, yeah. thanks for the catch. |
otan
force-pushed
the
version_gate_operators
branch
2 times, most recently
from
c4833a6 to
763d825
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, 4 of 4 files at r4.
Reviewable status:
Release note (sql change): box2d comparison operators are now gated by the cluster setting `sql.spatial.experimental_box2d_comparison_operators.enabled`.
otan
force-pushed
the
version_gate_operators
branch
from
763d825 to
d60618d
Compare
|
bors r=rytaft |
|
Build succeeded: |
Release note (sql change): box2d comparison operators are now gated by
the cluster setting
sql.spatial.experimental_box2d_comparison_operators.enabled.