Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add deprecation notice to dump CLI command #54044

Merged
merged 1 commit into from
Sep 8, 2020
Merged

cli: add deprecation notice to dump CLI command #54044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/cli/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,7 +1423,6 @@ Available Commands:
statement-diag commands for managing statement diagnostics bundles
auth-session log in and out of HTTP sessions
node list, inspect, drain or remove nodes
dump dump sql tables

nodelocal upload and delete nodelocal files
userfile upload, list and delete user scoped files
Expand Down
2 changes: 2 additions & 0 deletions pkg/cli/dump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ Dump SQL tables of a cockroach database. If the table name
is omitted, dump all tables in the database.
`,
RunE: MaybeDecorateGRPCError(runDump),
Deprecated: "cockroach dump will be removed in a subsequent release.\n" +
"For details, see: https://github.com/cockroachdb/cockroach/issues/54040",
}

// We accept versions that are strictly newer than v2.1.0-alpha.20180416
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ var nodeCmds = []*cobra.Command{

var nodeCmd = &cobra.Command{
Use: "node [command]",
Short: "list, inspect, drain or remove nodes",
Short: "list, inspect, drain or remove nodes\n",
Long: "List, inspect, drain or remove nodes.",
RunE: usageAndErr,
}
Expand Down