jobs: downgrade panic to log in deprecated path #54114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must have changed recently. I'll investigate what happened later. Release justification: fixes for high-priority or high-severity bugs in existing functionality Release note: None
|
This change is |
|
cc @tbg |
|
Ah, nice. Then I'll hold off on the skip. Thanks for jumping on this. |
tbg
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Will also need a backport to the release branch. Let me know what changed to trigger this now when you find out, I have no idea. Maybe @irfansharif's work on the server startup path jiggled things around ever so slightly?
spaskob
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
This one is concerning.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @spaskob)
Yes, it is. I'll dig later. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must have changed recently. I'll investigate what happened later.
Fixes #54079
Release justification: fixes for high-priority or high-severity bugs in
existing functionality
Release note: None