release-20.2: vendor: bump Pebble to e9a2c44e0bf1 #54185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
changed the title
itsbilal
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
go.mod, line 154 at r1 (raw file):
golang.org/x/perf v0.0.0-20180704124530-6e6d33e29852 golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e golang.org/x/sys v0.0.0-20200909081042-eff7692f9009
I think you'll have to revert these changes again. I've started to manually revert all the hunks other than the Pebble one after running go get -u, or else the build doesn't succeed.
Yeah, I'll do that again for this PR. I filed #54193 for fixing the incompatibility with the current version of golang.org/x/sys. |
jbowens
force-pushed
the
jackson/pebble-e9a2c44e0bf1
branch
2 times, most recently
from
859ee08
to
293be24
Compare
``` e9a2c44e db: close previous WAL before linking next WAL ``` Release note (bug fix): Fixes a bug whereby a crash during WAL rotation could cause Cockroach to error on restart reporting corruption.
jbowens
force-pushed
the
jackson/pebble-e9a2c44e0bf1
branch
from
293be24
to
86f637d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54142.
Release note (bug fix): Fixes a bug whereby a crash during WAL rotation
could cause Cockroach to error on restart reporting corruption.