release-20.2: sql: slurp bytes when receiving big CopyIn message #54187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release justification: low risk change to existing functionality Release note (bug fix): Previously, when using CopyIn with an extremely large message, the TCP connection would close with no discernable error. This is changed to now display that the message is too big.
|
This change is |
40 tasks
solongordon
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54066.
/cc @cockroachdb/release
Realised this whilst doing a post-PR reflection, curious if you think we should make this go in as well.
Refs #50330
Release justification: low risk change to existing functionality
Release note (bug fix): Previously, when using CopyIn with an extremely
large message, the TCP connection would close with no discernable error.
This is changed to now display that the message is too big.