sql: allow CONNECTION LIMIT syntax for CREATE DATABASE #54219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
connection_limit
branch
2 times, most recently
from
1ab69bc
to
928862e
Compare
|
I think treating the -1 case as no-op is good, but I'm not comfortable about ignoring every other value.
The issue here is that we want to support it later. If we ignore it today, we're telling users they can stuff arbitrary values there **with the guarantee crdb will ignore it**. So if we ever want to do something with the value we'll need first one deprecation cycle for the current behavior and then only change it.
That's a general principle btw - ignoring values is the dual of guaranteeing it doesn't matter and offering "this is a placeholder for arbitrary values" as a long-term supported feature.
…--
Verstuurd vanaf mijn Android apparaat met K-9 Mail. Excuseer mijn beknoptheid.
|
|
ah i misread the ticket. can make this error for != -1. |
otan
force-pushed
the
connection_limit
branch
2 times, most recently
from
720e6df
to
42be422
Compare
Release note (sql change): Added the ability to parse the `CONNECTION LIMIT [=] iconst32` syntax for `CREATE DATABASE`. This is currently a no-op for -1 (default, unlimited connections), and errors for any other value.
otan
force-pushed
the
connection_limit
branch
from
42be422
to
bb25412
Compare
arulajmani
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Looks good
Reviewed 2 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @solongordon)
|
bors r=arulajmani |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54116.
Release note (sql change): Added the ability to parse the
CONNECTION LIMIT [=] iconst32syntax forCREATE DATABASE. This is currently ano-op for -1 (default, unlimited connections), and errors for any
other value.