release-20.2: sql: fix DROP COLUMN bug which ignores containing indexes #54262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllNonDropIndexes returns an array of pointers to index descriptors. After deleting one of the indexes, the array of pointers point to a different element. This ends up accidentally missing some indexes that require deletion. Release note (bug fix): Fixed a bug introduced in earlier v20.2 versions where when attempting to drop a column which is referenced by multiple indexes fails to drop all relevant indexes.
|
This change is |
40 tasks
thoszhang
approved these changes
Sep 14, 2020
|
I approved this because it was in the Schema section of the backport request list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54228.
/cc @cockroachdb/release
AllNonDropIndexes returns an array of pointers to index descriptors.
After deleting one of the indexes, the array of pointers point
to a different element. This ends up accidentally missing some
indexes that require deletion.
Resolves #54196 (introduced in #51661).
Release note (bug fix): Fixed a bug introduced in earlier v20.2 versions
where when attempting to drop a column which is referenced by multiple
indexes fails to drop all relevant indexes.