Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_Angle #54307

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

erikgrinaker
Copy link
Contributor

Release note (sql change): Implement the geometry builtin ST_Angle

Closes #48866.
Closes #48867.

@blathers-crl
Copy link

blathers-crl bot commented Sep 12, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Sep 12, 2020
@blathers-crl blathers-crl bot requested a review from otan September 12, 2020 12:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (sql change): Implement the geometry builtin `ST_Angle`
@blathers-crl
Copy link

blathers-crl bot commented Sep 12, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 14, 2020

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 14, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 14, 2020

Build succeeded:

@craig craig bot merged commit a62a0f8 into cockroachdb:master Sep 14, 2020
@erikgrinaker erikgrinaker deleted the st_angle branch March 19, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner
Projects
None yet
3 participants