opt: fix st_distance -> st_dwithin rule to cast distance param as float #54366
Conversation
Release justification: low-risk updates to new functionality This commit fixes an error that could occur when the normalization rule was applied that converts st_distance(g1, g2) <= d to st_dwithin(g1, g2, d). The error occurred when d, the distance parameter, was some type other than float. Since st_dwithin requires the distance parameter to have type float, this commit fixes the problem by casting the parameter to type float. Fixes cockroachdb#54326 Release note (bug fix): fixed an internal error and/or panic that could occur when the ST_Distance or ST_MaxDistance functions were compared against a constant or variable with any type other than float. For example, previously, a query with the predicate `WHERE ST_Distance(g1, g2) < 10::int` could cause an error.
|
This change is |
There was a problem hiding this comment.
LGTM, small question
Reviewed 2 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mgartner, @otan, @RaduBerinde, and @rytaft)
pkg/sql/opt/norm/testdata/rules/comp, line 849 at r1 (raw file):
# Regression test for #54326. Ensure the distance param is cast to a float. norm expect=FoldCmpSTDistanceLeft format=(show-scalars,show-types) SELECT * FROM geom_geog WHERE st_distance(geog, 'point(0.0 0.0)') < 5::int
does this error appropriately for other types, e.g. string?
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
TFTRs!
Reviewable status:
pkg/sql/opt/norm/testdata/rules/comp, line 849 at r1 (raw file):
Previously, otan (Oliver Tan) wrote…
does this error appropriately for other types, e.g.
string?
It gives a type checking error (this was already working before): unsupported comparison operator: <float> < <string>.
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Release justification: low-risk updates to new functionality
This commit fixes an error that could occur when the normalization rule was
applied that converts
st_distance(g1, g2) <= dtost_dwithin(g1, g2, d).The error occurred when
d, the distance parameter, was some type other thanfloat. Sincest_dwithinrequires the distance parameter to have typefloat,this commit fixes the problem by casting the parameter to type
float.Fixes #54326
Release note (bug fix): fixed an internal error and/or panic that could occur
when the ST_Distance or ST_MaxDistance functions were compared against a
constant or variable with any type other than float. For example, previously,
a query with the predicate
WHERE ST_Distance(g1, g2) < 10::intcould cause anerror.