release-20.2: opt: unwrap explain.Node in ConstructScanBuffer #54419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
40 tasks
When the new explain infrastructure is in use, the plan is built against an explain.Factory but the "inner" recursive CTE plan is built against a normal factory. This leads to an internal error. To avoid this, we unwrap the node in `ConstructScanBuffer`. Note that the new explain infrastructure is used automatically for the first instance of a query fingerprint, in order to populate the plan in the UI. Fixes cockroachdb#54324. Release note (bug fix): fixed an internal error in some cases when recursive CTEs are used.
RaduBerinde
force-pushed
the
backport20.2-54325
branch
from
f3832d0
to
5d0bdea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54325.
/cc @cockroachdb/release
When the new explain infrastructure is in use, the plan is built
against an explain.Factory but the "inner" recursive CTE plan is built
against a normal factory. This leads to an internal error. To avoid
this, we unwrap the node in
ConstructScanBuffer.Note that the new explain infrastructure is used automatically for the
first instance of a query fingerprint, in order to populate the plan
in the UI.
Fixes #54324.
Release note (bug fix): fixed an internal error in some cases when
recursive CTEs are used.