sql: ensure that CREATELOGIN is needed for CREATE USER #55368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
solongordon
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @solongordon)
|
Looks good though needs a logic test update. |
|
Thanks! bors r=rsolongordon |
|
Build failed: |
|
bors r=rsolongordon |
|
Build failed: |
|
flake: #55403 bors r=solongordon |
|
Build failed: |
|
another flake: #55407 bors r=solongordon |
|
Build failed: |
Release note (bug fix): The `CREATE USER` statement without explicit NOLOGIN option implicitly grants LOGIN, and so requires the CREATELOGIN privilege. This was not checked properly, and is now enforced. This bug was introduced earlier in the v20.2 development cycle.
|
bors r=solongordon |
craig bot
pushed a commit
that referenced
this pull request
Oct 13, 2020
55368: sql: ensure that CREATELOGIN is needed for CREATE USER r=solongordon a=knz Fixes #55367 Release note (bug fix): The `CREATE USER` statement without explicit NOLOGIN option implicitly grants LOGIN, and so requires the CREATELOGIN privilege. This was not checked properly, and is now enforced. This bug was introduced earlier in the v20.2 development cycle. Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
|
Build failed: |
|
new/different flake: #55497 bors r=solongordon |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55367
Release note (bug fix): The
CREATE USERstatement without explicitNOLOGIN option implicitly grants LOGIN, and so requires the
CREATELOGIN privilege. This was not checked properly, and is now
enforced. This bug was introduced earlier in the v20.2 development
cycle.