Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump Pebble to b79d619f4761 #55388

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Oct 9, 2020

b79d619f sstable: skip readahead ramp-up for compactions
ab86f22f db: fix L0->LBase input expansion
879f3bfe db: changes to make iterators respect the bounds specified by the caller
91e8175b db: fix L0->LBase compaction picking bug with shared largest user keys
4e0eb739 db: fix WAL checksum error handling from previous versions
a69a94e1 db: optimize levelIter for repeated seeks with narrow and monotonic bounds
d670ff50 metamorphic: enhance iterSetBounds and position iter when setting bounds
b5c5df03 *: Add a simple test for forced compactions

Fix #55361.
Fix #54729.

Release note: None

b79d619f sstable: skip readahead ramp-up for compactions
ab86f22f db: fix L0->LBase input expansion
879f3bfe db: changes to make iterators respect the bounds specified by the caller
91e8175b db: fix L0->LBase compaction picking bug with shared largest user keys
4e0eb739 db: fix WAL checksum error handling from previous versions
a69a94e1 db: optimize levelIter for repeated seeks with narrow and monotonic bounds
d670ff50 metamorphic: enhance iterSetBounds and position iter when setting bounds
b5c5df03 *: Add a simple test for forced compactions

Fix cockroachdb#55361.
Fix cockroachdb#54729.

Release note: None
@jbowens jbowens requested a review from itsbilal October 9, 2020 18:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm relieved this was the cause of the roachtest failures.

@jbowens
Copy link
Collaborator Author

jbowens commented Oct 9, 2020

LGTM. I'm relieved this was the cause of the roachtest failures.

TFTR!

I'm not sure if the absence of 4e0eb739 could cause the issue in the encrypted switch engine roachtest (#55362) though. I'm going to try to repro it on the 20.2 branch.

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 9, 2020

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 10, 2020

Build succeeded:

@craig craig bot merged commit f5bd55d into cockroachdb:master Oct 10, 2020
@jbowens jbowens deleted the jackson/pebble-b79d619f4761 branch October 10, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: engine/switch/nodes=3 failed roachtest: join-init/mixed failed
3 participants